Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add Onboarding View (only UI) #284

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

maartinj
Copy link
Contributor

What it Does

  • Related to FEATURE - Onboarding UI #40
  • When app will be launch for the first time, will be presented 2 onboarding screens
  • 1st screen present the highlighted features of the app
  • 2nd screen allows to add basic data about first car
  • This pull request contains only UI (logic to remember app state whether User launched app for the first time or launched already, is commented. No more different logic is not included)
  • 1st and 3rd bullet point description had to be shortened due to SwiftLint policy

How I Tested

  • Run the application in Preview
  • Run the application in Simulator (with temporary logic turned on to show whether WelcomeScreen is loading when app is launched for the first time)
  • Check whether view components are shown correctly based on the design created in Figma

Notes

  • May need further updates to include logic when app is launched for the first time and to remember to not load onboarding screens when app is launched again

Screenshots

Screencast

Works only with temporary logic turned on (video only shows how Onboarding screens looks in simulator)

40-onboardingui-only-temporarylogic.mov

@mikaelacaron
Copy link
Owner

Thanks for the PR! I see this! I haven't had time yet to review it @maartinj

Rather than WelcomeScreen and WelcomeScreenDetails. fix some indentation, and the project wasn't built with all the strings properly
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally getting around to finishing up this app! Thanks so much for contributing and your patience!!

tiny note on your PR, I changed the name of the views to WelcomeView and WelcomeViewAddVehicle, rather than WelcomeScreen and WelcomeScreenDetails and when making the pointView the title and subTitle should be a LocalizedStringKey, which makes the strings get added to the Localizable.xcstrings file better. and I noticed there were several strings missing from that file, which makes me think you made the SwiftUI view, but then forgot to build the project

But again thank you for contributing and thanks for waiting so long for me to get to this!

@mikaelacaron mikaelacaron merged commit 6c40d55 into mikaelacaron:dev Jul 9, 2024
1 of 2 checks passed
@maartinj maartinj deleted the 40-onboardingui-only branch July 9, 2024 22:19
@maartinj maartinj restored the 40-onboardingui-only branch July 9, 2024 22:19
@maartinj maartinj deleted the 40-onboardingui-only branch July 9, 2024 22:19
@maartinj
Copy link
Contributor Author

maartinj commented Jul 9, 2024

@mikaelacaron Sure, you welcome 😊 Happy to help with other tasks 👍

@mikaelacaron
Copy link
Owner

Thank you! I can message you here or DM me, I have very specific issues I want to do to wrap everything up and get it shipped this month

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants