Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: Ctrl + Return does not work #423

Closed
1 task done
mikekazakov opened this issue Oct 13, 2024 · 0 comments
Closed
1 task done

[Bug]: Ctrl + Return does not work #423

mikekazakov opened this issue Oct 13, 2024 · 0 comments

Comments

@mikekazakov
Copy link
Owner

Confirmation

  • I have read the contributing guidelines

Version of Nimble Commander

v1.7, MacOS15

Distribution Type

Downloaded from GitHub (nightly and test workflows)

Expected Result

When pressing Ctrl + Return in file panels a pop-up context menu should be shown next to the focused item.

Actual Result

NC beeps and does nothing.

Steps to reproduce

  1. Open NC
  2. Move the cursor to any item
  3. Press Ctrl + Return

Additional Information

Ctrl + Return is now processed by AppKit itself. It shows a view's assigned menu, which NC does not set.
See https://developer.apple.com/videos/play/wwdc2024/10124/?time=528

While it's possible to start assigning menus to the views representing the file items, I'd prefer to leave the current approach of explicitly creating the menus on-demand (see panelView: requestsContextMenuForItemNo:). The same functionality can be instead added as a new action with the same hotkey. The benefits are: 1) level of control 2) providing the functionality to users on MacOS version before Sequoia.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant