Mail::Header: resolve performance issue #369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mail::Header#charset
is called pretty often during header parser work.If there are large amount of headers
#[]
is pretty slow.There is already
@charset
variable, but it doesn't speed up thecharset
method. This patch makes headers parsing faster by keeping@charset
variable always up to date and speeding up thecharset
method .Benchmark code:
Benchmark: https://gist.github.com/6b84d985c4e2b29dbb80
Result (with patch and without patch):