Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Restore macro binary compatibility with 2.3.3 #1153

Merged
merged 1 commit into from
May 7, 2021
Merged

Restore macro binary compatibility with 2.3.3 #1153

merged 1 commit into from
May 7, 2021

Conversation

joroKr21
Copy link
Collaborator

@joroKr21 joroKr21 commented May 7, 2021 •
edited
Loading

I thought this would be too hard, but actually it was not. CC @xuwei-k
Well, it is quite difficult in fact - see the CI failures.

@joroKr21 joroKr21 self-assigned this May 7, 2021
@joroKr21
Restore macro binary compatibility with 2.3.3
39448ca 
I thought this would be too hard, but actually it was not.
@joroKr21 joroKr21 force-pushed the macro-bincompat branch from c0ec144 to 39448ca Compare May 7, 2021 08:37
@milessabin milessabin self-requested a review May 7, 2021 13:33
milessabin
milessabin approved these changes May 7, 2021
View reviewed changes
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 merged commit 8a9d336 into milessabin:series/2.3 May 7, 2021
@joroKr21 joroKr21 deleted the macro-bincompat branch May 7, 2021 13:50
@travisbrown travisbrown mentioned this pull request May 11, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@milessabin milessabin milessabin approved these changes

Assignees

@joroKr21 joroKr21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joroKr21 @milessabin