Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

When case class has custom unapply, reference getters instead #1255

Merged
merged 1 commit into from
Mar 26, 2022
Merged

When case class has custom unapply, reference getters instead #1255

merged 1 commit into from
Mar 26, 2022

Conversation

joroKr21
Copy link
Collaborator

Fixes #1059

@joroKr21 joroKr21 self-assigned this Mar 25, 2022
@joroKr21 joroKr21 added the Bug label Mar 25, 2022
@joroKr21 joroKr21 marked this pull request as ready for review March 25, 2022 23:14
@joroKr21 joroKr21 requested a review from milessabin March 25, 2022 23:14
milessabin
milessabin approved these changes Mar 26, 2022
View reviewed changes
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 merged commit dff5dac into milessabin:main Mar 26, 2022
@joroKr21 joroKr21 deleted the custom-unappy branch March 26, 2022 17:45
@joroKr21 joroKr21 mentioned this pull request Mar 26, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@milessabin milessabin milessabin approved these changes

Assignees

@joroKr21 joroKr21

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find Generic instance if object has explicit "unapply" method since Scala 2.13.4
2 participants
@joroKr21 @milessabin