Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support all sam local cli options #2

Merged

Conversation

b6pzeusbc54tvhw5jgpyw8pwz2x6gs
Copy link
Contributor

@ofhouse
Copy link
Member

ofhouse commented Mar 14, 2021

Wow, adding all options is a huge improvement, thanks!
Never thought too much about testing for this module since it is only used in test context itself.

lib/generateProxyModel.ts is used by terraform-aws-next-js, I will check the compatibility there before releasing a new version 👍

Copy link
Member

@ofhouse ofhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with terraform-aws-next-js and is working.
LGTM 👍

@ofhouse ofhouse merged commit 837504b into milliHQ:main Mar 14, 2021
@ofhouse
Copy link
Member

ofhouse commented Mar 14, 2021

Now released as v1.5.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants