-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for grids #23
Conversation
This support is basic so far, and only for continuous views for now. The user can choose how many grid points they wish to use for each axis (defaults to 3 each), and the colour of the grid lines (defaults to a grey colour).
Looks good 😄 We probably don't want vertical grid lines for discrete views anyway so it makes sense to focus on continuous first. Could you add a line to the CHANGELOG for this? |
Turns out it's not markdown after all...
Update changelog |
I'm happy to merge this if you're ready? |
I think I'd like to have it at least implemented for |
Categorical views only show horizontal lines, whereas continuous views show lines in both directions.
This puts the data in front of the grid, which is more akin to how matplotlib renders grids. Grids should be relatively low in the z axis.
There we go, horizontal grid lines for I've also dropped the grid's z ordering down so that plot points and lines show up above the grid. @milliams how do you feel about this? matplotlibplotlib |
I think I prefer your style with the grid lines in the background and the data points on top. |
Glad to hear it. Just updated the documentation and fetched the latest changes from master. It's still probably not feature complete, but we can build smaller features on top of this. I think we should merge this as it is. Some thoughts I have:
|
You're right that there're a bunch more features that we need to add to this in the future. Feel free to open issues for some of those improvements or we can just refer back to this PR. |
This support is basic so far, and only for continuous views for now.
The user can choose how many grid points they wish to use for each axis
(defaults to 3 each), and the colour of the grid lines (defaults to a
grey colour).
Additionally abstract two functions for drawing horizontal/vertical lines.