-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: reduce bundle size #453
base: v1-migration
Are you sure you want to change the base?
Conversation
gregdolby
commented
Oct 15, 2024
- Removed 'joi'
- created custom publish options validation (our joi validation wasn't doing much in the first place, just warnings. all undefined properties would be validated)
- added tests for custom validation
- removed excess bundled files. only es module build with types exists now
|
I am working through this e2e test failure and it has to do with the build output. Puppeteer needs umd build but I am trying to figure out how to get it to work with es module bundle. |
I ended up adding umd bundle back. Jest tests and puppeteer run in node and they both support esm but for jest it is experimental. |