Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add createPrivilegeGroup/dropPrivilegeGroup/listPrivilegeGroups/addPrivilegesToGroup/removePrivilegesFromGroup #394

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

shanghaikid
Copy link
Contributor

No description provided.

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (b57d2d9) to head (f2be254).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   97.28%   97.31%   +0.02%     
==========================================
  Files          43       43              
  Lines        2877     2906      +29     
  Branches      712      718       +6     
==========================================
+ Hits         2799     2828      +29     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@shanghaikid shanghaikid merged commit 1ffa69d into main Dec 24, 2024
4 of 5 checks passed
@shanghaikid shanghaikid deleted the feat/support-privilege-group branch December 24, 2024 08:41
shanghaikid added a commit that referenced this pull request Dec 24, 2024
…ivilegesToGroup/removePrivilegesFromGroup (#394)

* add apis

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

* finish

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

* add more tests

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

---------

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants