Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance: decrease CPU overhead when calculating index file size #36580

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

issue: #36578
pr: #36579

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 27, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 27, 2024
Signed-off-by: jaime <yun.zhang@zilliz.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (e5a6c5b) to head (878767b).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36580      +/-   ##
==========================================
- Coverage   71.91%   71.89%   -0.03%     
==========================================
  Files        1064     1064              
  Lines      140331   140335       +4     
==========================================
- Hits       100925   100894      -31     
- Misses      35089    35109      +20     
- Partials     4317     4332      +15     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 95.73% <100.00%> (+0.08%) ⬆️
internal/datacoord/meta.go 89.88% <100.00%> (-0.07%) ⬇️

... and 32 files with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants