Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance:use proto.clone in compaction tasks to prevent omissions #36624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wayblink
Copy link
Collaborator

issue: #36623

@wayblink wayblink changed the title enhance:use proto.clone in compaction tasks to prvent omissions enhance:use proto.clone in compaction tasks to prevent omissions Sep 30, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 30, 2024
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 30, 2024
Copy link
Contributor

mergify bot commented Sep 30, 2024

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

@wayblink
Copy link
Collaborator Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (00a5025) to head (fc0f182).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36624      +/-   ##
==========================================
- Coverage   82.33%   81.45%   -0.88%     
==========================================
  Files        1286     1286              
  Lines      152078   152059      -19     
==========================================
- Hits       125208   123860    -1348     
- Misses      21837    23146    +1309     
- Partials     5033     5053      +20     
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_clustering.go 78.80% <100.00%> (-1.20%) ⬇️
internal/datacoord/compaction_task_l0.go 100.00% <100.00%> (ø)
internal/datacoord/compaction_task_mix.go 61.77% <100.00%> (-3.94%) ⬇️

... and 101 files with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants