Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: float16 parsing accuracy issue in csv #36633

Closed
wants to merge 1 commit into from

Conversation

OxalisCu
Copy link
Contributor

@OxalisCu OxalisCu commented Sep 30, 2024

Signed-off-by: OxalisCu <2127298698@qq.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OxalisCu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 59.42029% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (00a5025) to head (6a06163).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/importutilv2/csv/row_parser.go 59.42% 17 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36633      +/-   ##
==========================================
- Coverage   82.33%   80.55%   -1.78%     
==========================================
  Files        1286     1273      -13     
  Lines      152078   150799    -1279     
==========================================
- Hits       125208   121480    -3728     
- Misses      21837    24282    +2445     
- Partials     5033     5037       +4     
Files with missing lines Coverage Δ
internal/util/importutilv2/csv/row_parser.go 65.49% <59.42%> (-4.18%) ⬇️

... and 251 files with indirect coverage changes

@OxalisCu OxalisCu closed this Oct 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants