Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance: Optimize datacoord meta mutex #40552

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Use a separate collection mutex.
  2. Avoid holding locks for extended periods, such as in GetQuotaInfo. (TODO)

issue: #40551

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 11, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby March 11, 2025 07:02
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 11, 2025
@dosubot dosubot bot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (0420dc1) to head (e481353).
Report is 4 commits behind head on master.

❌ Your project check has failed because the head coverage (70.00%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (0420dc1) and HEAD (e481353). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0420dc1) HEAD (e481353)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40552       +/-   ##
===========================================
- Coverage   80.50%   70.00%   -10.51%     
===========================================
  Files        1474      309     -1165     
  Lines      207669    27722   -179947     
===========================================
- Hits       167192    19406   -147786     
+ Misses      34400     8316    -26084     
+ Partials     6077        0     -6077     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 70.00% <ø> (ø)
Go ∅ <ø> (∅)

see 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 11, 2025
@bigsheeper
Copy link
Contributor Author

related to #37630

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Mar 12, 2025
@mergify mergify bot removed the ci-passed label Mar 12, 2025
Copy link
Contributor

mergify bot commented Mar 12, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 12, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants