Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

strip whitespace from commands by default #427

Merged

Conversation

devvmh
Copy link
Contributor

@devvmh devvmh commented Sep 2, 2016

before, this code would have an issue:

command %(
  if [[ $condition ]]; then
    do_something
  else
    dont_do_something
  fi
)

where there would be a parse error on the previous line because of a blank line, e.g.

previous_command &&

if [[ $condition ]]; then
...

The blank line would cause an issue. This commit fixes that

before, this code would have an issue:

    command %(
      if [[ $condition ]]; then
        do_something
      else
        dont_do_something
      fi
    )

where there would be a parse error on the previous line because of a blank line, e.g.

    previous_command &&

    if [[ $condition ]]; then
    ...

The blank line would cause an issue. This commit fixes that
@devvmh devvmh force-pushed the feature/command-strip-whitespace branch from 41654cb to d682cf7 Compare September 2, 2016 09:49
@devvmh
Copy link
Contributor Author

devvmh commented Sep 6, 2016

I want to fix CI, but I'm really confused by the output files and the output, and how to make it work. the messages from rspec seem different than what I'm seeing on my file system, and my local rspec has a failed task that Semaphore is missing. Any tips?

@d4be4st d4be4st merged commit d682cf7 into mina-deploy:master Sep 17, 2016
@d4be4st
Copy link
Member

d4be4st commented Sep 17, 2016

I fixed the rspec. Basically the '.txt' files are regex which should match the output

Thx for the PR

@devvmh devvmh deleted the feature/command-strip-whitespace branch September 19, 2016 02:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants