Point Trusty helm chart default to public instance #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
previously approved these changes
Dec 6, 2023
JAORMX
previously approved these changes
Dec 6, 2023
teodor-yanev
previously approved these changes
Dec 6, 2023
rdimitrov
reviewed
Dec 7, 2023
evankanderson
dismissed stale reviews from teodor-yanev, JAORMX, and rdimitrov
via
cf536af
evankanderson
force-pushed
the
in-prod-we-trusty
branch
from
e883f16 to
cf536af
Compare
It turns out I forgot to save |
evankanderson
commented
Dec 7, 2023
| @@ -16,6 +16,9 @@ hostname: "minder-test.example.com" | |||
| db: | |||
| host: postgres.postgres.svc | |||
|
|
|||
| trusty: | |||
| endpoint: http://trusty.trusty:8080 | |||
There was a problem hiding this comment.
I added this just to have a test of the values override.
rdimitrov
approved these changes
Dec 8, 2023
JAORMX
approved these changes
Dec 8, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were encoding some internal pre-launch configuration details in the public helm chart. This switches the defaults so they should work outside Stacklok's EKS cluster.