Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ingress configuration for data sources. #5186

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Dec 12, 2024

Summary

This is necessary to test Data Sources in staging. The lack of it causes a confusing HTTP 464 error with message malformed header: missing HTTP content-type.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Not tested, just a hunch.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is necessary to test Data Sources in staging. The lack of it
causes a confusing `HTTP 464` error with message `malformed header:
missing HTTP content-type`.
@blkt blkt self-assigned this Dec 12, 2024
@blkt blkt requested a review from a team as a code owner December 12, 2024 10:47
@blkt blkt merged commit 8502c32 into main Dec 12, 2024
22 of 24 checks passed
@blkt blkt deleted the fix/data-source-ingress branch December 12, 2024 10:52
@coveralls
Copy link

Coverage Status

coverage: 55.352%. remained the same
when pulling 733449a on fix/data-source-ingress
into f2d6feb on main.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants