Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

s_access_ip IPv6 #400

Closed
Tangol opened this issue Sep 29, 2021 · 1 comment
Closed

s_access_ip IPv6 #400

Tangol opened this issue Sep 29, 2021 · 1 comment

Comments

@Tangol
Copy link

Tangol commented Sep 29, 2021

At the moment, Osclass stores the user access IP as varchar(15) which is the standard for IPv4 (15 characters long).
https://github.com/mindstellar/Osclass/blob/master/oc-includes/osclass/installer/struct.sql#L143
https://github.com/mindstellar/Osclass/blob/master/oc-includes/osclass/installer/struct.sql#L126

The question is, what happens when a user accesses the website from an IPv6 address?
Does it get stored/returned correctly?

navjottomer added a commit that referenced this issue Sep 30, 2021
@navjottomer
Copy link
Member

Ipv6 get clipped, I have changed it to varchar(50) in the recent commit.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants