fix: update to newer mtdb version to fix resource issues. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from minetest-go#181
Gracefully flushes the remaining transactions for Sqlite. Requires new release of minetest-go/mtdb. Fixes minetest-go#180
ronoaldo
changed the title
|
Blocked until a newer release of mtdb with minetest-go/mtdb#78 is made. |
|
I believe this will also fix #179 - the recent commits from mtdb that release read rows from Sqlite backend should no longer retain memory there. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #181 by moving the log statement to be executed after nil check.
This should also fixe #180 as there is now a defer to close the Sqlite database at the end of export.