Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add pre-commit to verify commit before create PR #1066

Merged
merged 5 commits into from
Nov 25, 2024
Merged

add pre-commit to verify commit before create PR #1066

merged 5 commits into from
Nov 25, 2024

Conversation

tvqphuoc01
Copy link
Collaborator

@tvqphuoc01 tvqphuoc01 commented Nov 23, 2024 •
edited
Loading

  1. add pre-commit using isort, black and pep
  2. add pre-commit pipeline

@tvqphuoc01 tvqphuoc01 self-assigned this Nov 23, 2024
gabriel-tessier
gabriel-tessier approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@tvqphuoc01 tvqphuoc01 merged commit fa48533 into master Nov 25, 2024
8 checks passed
@tvqphuoc01 tvqphuoc01 deleted the add-pep8-black-check-pipeline-before-run-build branch November 25, 2024 12:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gabriel-tessier gabriel-tessier gabriel-tessier approved these changes

@mingrammer mingrammer Awaiting requested review from mingrammer

@filipeaaoliveira filipeaaoliveira Awaiting requested review from filipeaaoliveira

Assignees

@tvqphuoc01 tvqphuoc01

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvqphuoc01 @gabriel-tessier