fix: Include type for OPML subscriptions #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per [OPML 2.0 specification]: > Each sub-element of the body of the OPML document is a node of type rss or an outline element that contains nodes of type rss. > Required attributes: type, text, xmlUrl. [OPML 2.0 specification]: http://opml.org/spec2.opml#subscriptionLists
|
Without this patch: <?xml version="1.0" encoding="UTF-8"?>
<opml version="2.0">
<head>
<title>Miniflux</title>
<dateCreated>Wed, 20 Dec 2023 07:27:34 CET</dateCreated>
</head>
<body>
<outline text="All">
<outline title="http://feeds.feedburner.com/felixcat" text="http://feeds.feedburner.com/felixcat" xmlUrl="http://feeds.feedburner.com/felixcat" htmlUrl="http://feeds.feedburner.com/felixcat"></outline>
<outline title="https://www.archlinux.org/feeds/news/" text="https://www.archlinux.org/feeds/news/" xmlUrl="https://archlinux.org/feeds/news/" htmlUrl="https://www.archlinux.org/feeds/news/"></outline>
</outline>
</body>
</opml>With this patch: <?xml version="1.0" encoding="UTF-8"?>
<opml version="2.0">
<head>
<title>Miniflux</title>
<dateCreated>Wed, 20 Dec 2023 07:39:24 CET</dateCreated>
</head>
<body>
<outline text="All">
<outline title="http://feeds.feedburner.com/felixcat" text="http://feeds.feedburner.com/felixcat" xmlUrl="http://feeds.feedburner.com/felixcat" htmlUrl="http://feeds.feedburner.com/felixcat" type="rss"></outline>
<outline title="https://www.archlinux.org/feeds/news/" text="https://www.archlinux.org/feeds/news/" xmlUrl="https://archlinux.org/feeds/news/" htmlUrl="https://www.archlinux.org/feeds/news/" type="rss"></outline>
</outline>
</body>
</opml> |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per OPML 2.0 specification:
Do you follow the guidelines?