fix drive name of volume at startup if needed #873
Conversation
|
I need to test this on real machines before merging |
Praveenrajmani
force-pushed
the
sync_drive_names_in_volumes
branch
2 times, most recently
from
16e63a7 to
3b1ae6d
Compare
Praveenrajmani
force-pushed
the
sync_drive_names_in_volumes
branch
from
3b1ae6d to
01ff2d8
Compare
| volume := object.(*types.Volume) | ||
| if !volume.GetDeletionTimestamp().IsZero() { | ||
| return handler.delete(ctx, volume) | ||
| } | ||
|
|
||
| if eventType == controller.AddEvent { |
There was a problem hiding this comment.
For existing volumes, Add event occurs only at start of the controller. This is same as added into Sync(). As volumes live for very long, we could add drive name update every day once in future.
There was a problem hiding this comment.
Do you want to keep this in Update event handler? The reason i added this in Add event handler is because, this can happen only during the node restarts mostly.
Adding this in Update handler, makes these repeated GET calls to the respective drive objects.
If the drive order can change at runtime (considering it as a rare event), can we suggest them to restart the pods instead of checking everytimea at the update handler?
There was a problem hiding this comment.
Yep. We will add it later.
When a node-server starts, it syncs the drive states like drive name, capacity, make etc. This is because, the drive order wouldv'e changed during node restarts. In such scenarios, We need to also make sure to fix the drive name in corresponding volumes. Without this fix, the `kubectl directpv list volumes` command will show wrong drive names (if the node has restarted)
Praveenrajmani
force-pushed
the
sync_drive_names_in_volumes
branch
from
01ff2d8 to
0a11728
Compare
balamurugana
changed the title
When a node-server starts, it syncs the drive states like drive name, capacity, make etc. This is because, the drive order wouldv'e changed during node restarts.
In such scenarios, We need to also make sure to fix the drive name in corresponding volumes. Without this fix, the
kubectl directpv list volumescommand will show wrong drive names (if the node has restarted)