Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: fix piped sh usage #930

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ $ kubectl directpv install --openshift
#### Installing by generating DirectPV manifests
To install using generated manifests file, run below command
```sh
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh - apply
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh -s - apply
```

## What's next
Expand Down
3 changes: 1 addition & 2 deletions docs/tools/push-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ function main() {
push_image "quay.io/minio/csi-provisioner:v2.2.0-go1.18"
push_image "quay.io/minio/livenessprobe:v2.13.1"
push_image "quay.io/minio/csi-resizer:v1.11.2"
release=$(curl -sfL "https://api.github.com/repos/minio/directpv/releases/latest" | awk '/tag_name/ { print substr($2, 3, length($2)-4) }')
push_image "quay.io/minio/directpv:v${release}"
push_image "quay.io/minio/directpv:v4.0.13"
}

init "$@"
Expand Down
2 changes: 1 addition & 1 deletion docs/upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Follow the below steps for an in-place upgrade
1. Upgrade DirectPV plugin by [this documentation](#upgrade-directpv-plugin).
2. Run install script with appropriate node-selector, tolerations, and `KUBELET_DIR_PATH` environment variable. Below is an example:
```sh
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh - apply
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh -s - apply
```

### Upgrade legacy DirectCSI CSI driver
Expand Down
Loading