This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Vastly simplified single Dockerfile based on ruby:2-webapp-onbuild image #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldavidson
force-pushed
the
moj-dockerails
branch
from
4b00a66 to
2f5845f
Compare
|
fixes #146 |
…ler, single Dockerfile based on ministryofjustice/ruby:2-webapp-onbuild. There is no development_ or production_ container anymore, just base_container and test_container (used in Jenkins for running CI tests)
aldavidson
force-pushed
the
moj-dockerails
branch
from
c7530bf to
f32c587
Compare
|
@mattpep have squashed down to 2 commits, ready for merge on monday |
mattpep
added a commit
that referenced
this pull request
Sep 28, 2015
Vastly simplified single Dockerfile based on ruby:2-webapp-onbuild image
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of the multiple, combined-on-the-fly Dockerfiles, and replaced with a single, much simpler Dockerfile based on ministryofjustice/ruby:2-webapp-onbuild