APS-2021: Cas1 offender entity. #3091
Conversation
| id UUID NOT NULL , | ||
| crn TEXT NOT NULL , | ||
| noms_number TEXT, | ||
| tier TEXT, |
There was a problem hiding this comment.
for the tier can we please use the custom collation specified in APS-1782. I've tried this locally, hopefully it works via flyway SQL:
CREATE COLLATION cas1_tier (provider = icu, locale = 'en-GB',
rules = $$
& ' ' <*a-z <*A-Z < 9 < 8 < 7 < 6 < 5 < 4 < 3 < 2 < 1 < 0
$$);
CREATE TABLE collation_test(
value text NULL COLLATE "cas1_tier"
);
| val nomsNumber: String?, | ||
| /** | ||
| * The offender name. This should only be used for search purposes (i.e. SQL) | ||
| * If returning the offender name to the user, use the [Cas1OffenderService], which |
There was a problem hiding this comment.
I think the reference in the comment should be to [OffenderService]
There was a problem hiding this comment.
Sorry, the ticket mentioned this. will revert.
Add a Cas1OffenderService to support this logic.
There was a problem hiding this comment.
Ah I see. In this case the OffenderService should still be used to retrieve information about an offender to present on the UI (i.e., the comment on this field is correct). Cas1OffenderService will only be used manage this offender service table.
I do think the naming is a bit confusing though so maybe it needs a rethink!
vbala-moj
force-pushed
the
feature/APS-2021-cas1-offender-entity
branch
from
bd36b38 to
dc51b91
Compare
vbala-moj
force-pushed
the
feature/APS-2021-cas1-offender-entity
branch
from
dc51b91 to
dbc6ff6
Compare
https://dsdmoj.atlassian.net/browse/APS-2021