Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Color Schemes not always switching immediately #251

Closed
lilsharu opened this issue Aug 8, 2020 · 6 comments
Closed

Color Schemes not always switching immediately #251

lilsharu opened this issue Aug 8, 2020 · 6 comments

Comments

@lilsharu
Copy link

lilsharu commented Aug 8, 2020

I have tried numerous color schemes, (many of them from base16-mintty), and most of them are rendering the same! I have tried changing numbers and values to no avail. I just reinstalled this and the issues started, never happened before.

Preinstalled Color Scheme HTML:
image

Preinstalled themes.zoo:
image

Preinstalled Mintty:
image

As you can see, these are all the same. Even custom color schemes do not work.

@lilsharu
Copy link
Author

lilsharu commented Aug 8, 2020

Update: It seems like after I copied a working color scheme, like nord, and retyped all of the config, it works. However, when I change the name to use the extension .minttyrc, the color scheme stops working. Is this an issue with mintty or with wsltty?

@mintty
Copy link
Owner

mintty commented Aug 8, 2020

I notice that in some cases the change is not made visible immediately but only after the windows is redisplayed, e.g. by simply moving it. Can you confirm this happens? Cause to be analysed.

@mintty mintty changed the title Color Schemes not properly working Color Schemes not always switching immediately Aug 10, 2020
@mintty
Copy link
Owner

mintty commented Aug 10, 2020

I changed the title as the themes actually work, just the feedback when switching may be delayed.
I observed delayed application when switching among themes "vga", "windows10", "xterm" on one machine, while other themes would switch immediately. I could not reproduce the issue on another machine, however, so it's still mysterious what happens.

@buiducanh
Copy link

https://github.com/morhetz/gruvbox-contrib/tree/master/mintty

I used gruvbox successfully with wsltty before but with the latest release 3.30, it doesn't change color at all if I put it under wsltty\themes\gruvbox.minttyrc

However, if I copy the theme values into wsltty\config, the color does show up. I think there might be a bug in how wsltty load the theme values from declared themes

@mintty
Copy link
Owner

mintty commented Sep 7, 2020

There were actually two problems. Fixed display of themes with '.minttyrc' filename suffix. And ensuring screen refresh.
I'll also include the gruvbox theme if that's OK.

@mintty
Copy link
Owner

mintty commented Oct 24, 2020

Released 3.4.1.

@mintty mintty closed this as completed Oct 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants