Update accordion.js, closes #444 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ricklambrechts
approved these changes
Jul 8, 2024
|
nice nice |
ppvg
reviewed
Jul 10, 2024
| @@ -45,7 +45,7 @@ function initAccordion(accordion) { | |||
| } | |||
|
|
|||
| // Set up the initial `aria-expanded` state. | |||
| if (button.getAttribute("aria-expanded")) { | |||
| if (button.getAttribute("aria-expanded") === "true") { | |||
There was a problem hiding this comment.
Does this break the use case of explicitly setting aria-expanded="false" on the first button in the markup to stop it from being expanded by default?
There was a problem hiding this comment.
It should not, and is more explicit, only an element with aria-expanded="true" should now be opened on page load.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should close #444 for pages that by accident mess up their accordion code