New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix!: filter icon positioning #616

Draft

HeleenSG wants to merge 2 commits into main from fix/filter-icon

Contributor

HeleenSG commented Aug 7, 2024 •

edited

Loading

Solves:

Icon positioning within filter button making it possible to position the icon to the left as well as to the right
Inconsistent variable name (::after --filter-button-icon-before...)

Todo:

Add span through JS

Breaking change:
Removes "--filter-button-icon-before-open-content" and "--filter-button-icon-before-close-content"

HeleenSG assigned HeleenSG and ppvg

HeleenSG added the breaking change label

HeleenSG added 2 commits

August 8, 2024 09:54


          Breaking change: Solves icon positioning within filter button

71a32b6


          Reinstates filter button icon line height var

58a4ba9

HeleenSG force-pushed the fix/filter-icon branch from 79838c9 to 58a4ba9 Compare

August 8, 2024 08:07

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

breaking change