Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(themes): resolve open-color map-get deprecation warning #759

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

ppvg
Copy link
Member

@ppvg ppvg commented Jan 28, 2025

The use of map-get in open-color.scss without @useing sass:map results in deprecation warnings when building a project that uses Manon.

Example deprecation warning
Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use map.get instead.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
36 │ $oc-gray-4: map-get($oc-gray-list, "4");
   │             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/@minvws/manon-themes/icore-open/color-scheme/open-color.scss 36:13  @forward
    node_modules/@minvws/manon-themes/icore-open/color-scheme/_index.scss 6:1        @use
    node_modules/@minvws/manon-themes/icore-open/application-base.scss 4:1           @use
    node_modules/@minvws/manon-themes/icore-open/theme.scss 10:1                     @forward
    node_modules/@minvws/manon-themes/icore-open/_index.scss 1:1                     @use
    resources/scss/manon/_theme.scss 1:1                                             @use
    resources/scss/manon/_index.scss 2:1                                             @use
    resources/scss/app.scss 2:1                                                      root stylesheet

Open-color was last updated in 2021. I don't expect it to be updated to fix this. We've already inlined open-color.scss in this repo, so it makes sense to fix it here. The relevant fix is in c14129a. The rest is some SPDX housekeeping and code formatting.

@ppvg ppvg marked this pull request as ready for review January 28, 2025 08:17
@ppvg ppvg requested a review from a team as a code owner January 28, 2025 08:17
Copy link

@randh1r randh1r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ppvg ppvg merged commit 7a6cec9 into main Jan 28, 2025
6 checks passed
@ppvg ppvg deleted the fix/open-color-map-get-deprecation-warning branch January 28, 2025 08:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants