Ensure internal errors in the test suite are displayed #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
show-internal-errors
branch
from
34f32a3 to
3d03a9b
Compare
This fixes a bug with the `test/e2e/*/passing` test suites in which internal failures (with exit code 125) were not dislayed in the test logs. This should make spurious test failures easier to debug. Partial fix for mirage#272.
This can easiliy be replaced by `(with-accepted-exit-codes ...)` now that we require Dune 2.2.
craigfe
force-pushed
the
show-internal-errors
branch
from
3d03a9b to
8862efa
Compare
|
Will merge this and #271 this evening if there are no outstanding objections 🙂 |
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Sep 7, 2020
…lwt (1.2.3) CHANGES: - Require Dune 2.2. (mirage/alcotest#274, @craigfe) - Fix a bug in the handling of the `~and_exit:false` option when the test suite fails. (mirage/alcotest#271, @craigfe)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the
test/e2e/*/passingtest suites in which internal failures (with exit code 125) were not dislayed in the test logs. This should make spurious test failures easier to debug.Partial fix for #272.