Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to async v0.15 #352

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Upgrade to async v0.15 #352

merged 2 commits into from
Jun 16, 2022

Conversation

crackcomm
Copy link
Contributor

Upgrade to async v0.15.

It might be undesirable but includes cmdliner >= "1.1.0" update.

PR submitted in hopes it might save some time for whom it may concern.

@TheLortex
Copy link
Member

TheLortex commented Jun 15, 2022

Hi @crackcomm, thank you for your PR.

I have force-pushed on your branch with a rebase on top of alcotest's main, and a fix for core's version (v0.15.0 vs 0.15.0).
It should be good to merge soon enough (looks like there is a formatting issue and the changelog entry is missing)

EDIT: because of the upgrade we're losing support for ocaml < 4.11 but I think that's ok

@TheLortex TheLortex force-pushed the main branch 5 times, most recently from 85ee1be to 8d55cc5 Compare June 16, 2022 08:23
@TheLortex TheLortex merged commit 3a34aa3 into mirage:main Jun 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants