Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

alcotest_stubs.c compile with MSVC #369

Merged
merged 1 commit into from
Feb 24, 2023
Merged

alcotest_stubs.c compile with MSVC #369

merged 1 commit into from
Feb 24, 2023

Conversation

jonahbeckford
Copy link
Contributor

unistd.h is not present in Windows SDK (MSVC) and usually unnecessary.

Before:

========= [TROUBLESHOOTING] alcotest-3480-337052.out ===========

[alcotest-3480-337052.out] File "src/alcotest/dune", line 6, characters 9-23:
[alcotest-3480-337052.out] 6 |   (names alcotest_stubs))
[alcotest-3480-337052.out]              ^^^^^^^^^^^^^^
[alcotest-3480-337052.out] (cd _build/default/src/alcotest && "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\bin\HostX64\x64\cl.exe" -nologo -O2 -Gy- -MD -D_CRT_SECURE_NO_DEPRECATE -nologo -O2 -Gy- -MD -I D:/.opam/dkml/lib/ocaml -I D:\.opam\dkml\lib\astring -I D:\.opam\dkml\lib\fmt -I ../alcotest-engine /Foalcotest_stubs.obj -c alcotest_stubs.c)
[alcotest-3480-337052.out] alcotest_stubs.c
[alcotest-3480-337052.out] alcotest_stubs.c(4): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory

@samoht
Copy link
Member

samoht commented Feb 24, 2023

Thanks! I trust @TheLortex and @MisterDA on this :-)

@samoht samoht merged commit 688cbe1 into mirage:main Feb 24, 2023
@samoht samoht mentioned this pull request Feb 24, 2023
Merged
samoht added a commit to samoht/opam-repository that referenced this pull request Feb 24, 2023
@samoht
[new release] alcotest, alcotest-mirage, alcotest-lwt, alcotest-js an…
ed16529 
…d alcotest-async (1.7.0)

CHANGES:

- compile with MSVC (mirage/alcotest#369, @jonahbeckfordm review by @TheLortex
  and @MisterDA)

- Allow skipping a test case from inside the test case (mirage/alcotest#368, @apeschar)

- Fix compilation on bytecode architectures (mirage/alcotest#335, @glondu)

- Get `alcotest_stubs.c` to compile with MSVC (mirage/alcotest#369, @jonahbeckford)

- Try automatically reporting the location of calls to Alcotest.check.
  (mirage/alcotest#366, @MisterDA, review by @TheLortex)

- Detect that Alcotest is running in CI and change output accordingly.
  (mirage/alcotest#364, @MisterDA)

- Upgrade to `dune >= 3.0`. (mirage/alcotest#360, @MisterDA)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MisterDA MisterDA MisterDA approved these changes

@TheLortex TheLortex TheLortex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonahbeckford @samoht @TheLortex @MisterDA