Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

raise to OCaml 4.07.0, remove dependency to compat packages #134

Merged
merged 3 commits into from
Apr 6, 2022
Merged

raise to OCaml 4.07.0, remove dependency to compat packages #134

merged 3 commits into from
Apr 6, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 6, 2022

No description provided.

@hannesm hannesm requested a review from dinosaure April 6, 2022 07:56
@dinosaure
Copy link
Member

I'm not sure about the error on 4.07. We should add bigarray as a dependency (I suspect that it's an otherlibs/ dependency) but such thing is incompatible with OCaml 5.00.0 if I remember correctly. /cc @kit-ty-kate Otherwise, it's fine to drop the 4.07 support - I mean, we already start that with cstruct which is widely used.

@kit-ty-kate
Copy link

i would also suggest dropping 4.07

@dinosaure
Copy link
Member

Thanks!

@dinosaure dinosaure merged commit a94075c into mirage:master Apr 6, 2022
@hannesm hannesm deleted the new branch April 6, 2022 17:10
@dinosaure dinosaure mentioned this pull request Apr 7, 2022
Closed
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Apr 8, 2022
@dinosaure
[new release] digestif (1.1.2)
5b65d42 
CHANGES:

- Minor update on the README.md (@punchagan, mirage/digestif#133)
- Support only OCaml >= 4.08, update with `ocamlformat.0.21.0` and remove `bigarray-compat`
  dependency (@hannesm, mirage/digestif#134)
@dinosaure dinosaure mentioned this pull request Apr 8, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@dinosaure dinosaure Awaiting requested review from dinosaure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannesm @dinosaure @kit-ty-kate