Delete the old MirageOS 3 trick #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such trick is to compile digestif with ocaml-solo5 and distribute it for MirageOS 3 then. We need to patch the generated META file from `dune` to finally install something good for MirageOS 3. It seems clear that at this date, we don't really need to continue the support of MirageOS. It seems that such trick bothers dune cache and installation on some platform. Let's just remove that.
|
we should put a conflict with ocaml-freestanding so that mirageos3 users aren't getting into trouble.. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Oct 20, 2022
CHANGES: - Support MSVC compiler (@jonahbeckford, mirage/digestif#137) - Fix CI on Windows (`test_conv.ml` requires `/dev/urandom`) (@dinosaure, mirage/digestif#138) - Fix threads support (@dinosaure, mirage/digestif#140) - Delete the META trick needed for MirageOS 3 when we install `digestif` (@dinosaure, mirage/digestif#141) This version of `digestif` breaks the compatibility with MirageOS 3 and `ocaml-freestanding`. This PR should unlock the ability to use `dune-cache`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such trick is to compile digestif with ocaml-solo5 and distribute it for MirageOS 3 then. We need to patch the generated META file from
duneto finally install something good for MirageOS 3.It seems clear that at this date, we don't really need to continue the support of MirageOS. It seems that such trick bothers dune cache and installation on some platform. Let's just remove that.
Fix #136