Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: tooltips sur les headers #3343

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: tooltips sur les headers #3343

merged 3 commits into from
Nov 7, 2023

Conversation

Copy link

github-actions bot commented Nov 7, 2023

To deploy this PR just add a comment with a simple 🚀

@rap2hpoutre
Copy link
Contributor Author

🚀

@rap2hpoutre
Copy link
Contributor Author

🚀 vasy réessaye

Copy link

github-actions bot commented Nov 7, 2023

🚑 Prévisualisation failed

https://3343.tdb-preview.apprentissage.beta.gouv.fr/

You can get error logs using .bin/mna-tdb deploy:log:decrypt 6783503081
You can access runner logs in ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}

To re-deploy just add a comment with 🚀

@rap2hpoutre
Copy link
Contributor Author

Bon bah tant pis pour la prévisualisation.

Copy link
Contributor

@totakoko totakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Juste un petit fix à faire avec les headers affichés quand il n'y a pas de tooltip.

ui/modules/organismes/Televersement.tsx Outdated Show resolved Hide resolved
</>
),
libelle_court_formation: (
<>Libellé court de la formation suivie par l’apprenant. Exemple : CAP Pâtissier (donnée facultative)</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osef des &nbsp; je pense 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg j'ai pas été vigilant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai vérifié dans les tooltips et j'ai pas vu de cas à problème en tout cas.

Co-authored-by: Maxime Dréau <totakoko@users.noreply.github.com>
@rap2hpoutre rap2hpoutre added this pull request to the merge queue Nov 7, 2023
Merged via the queue into master with commit 7faf275 Nov 7, 2023
7 checks passed
@rap2hpoutre rap2hpoutre deleted the tooltips-televersements branch November 7, 2023 14:31
Copy link

github-actions bot commented Nov 7, 2023

🎉 This PR is included in version 3.90.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kahovskaia
Copy link

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants