Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid updating the field again for the event source block #59

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

HollowMan6
Copy link
Collaborator

The basics

The details

Resolves

Fixes #58

Proposed Changes

Checking the event source and avoid calling the setFieldValue if that specific block happens to be the event source.

Reason for Changes

Avoid the validator to validate it twice.

Test Coverage

Documentation

Additional Information

Resolves mit-cml#58

Signed-off-by: Songlin Jiang <songlin.jiang@csc.fi>
@HollowMan6
Copy link
Collaborator Author

cc: @mark-friedman

@HollowMan6 HollowMan6 requested a review from ewpatton June 13, 2024 07:32
@HollowMan6 HollowMan6 added the bug Something isn't working label Jun 13, 2024
@HollowMan6 HollowMan6 merged commit 5bad049 into mit-cml:main Jun 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiFieldUpdate shouldn't cause excessive field updates
1 participant