Fix pollard serialization/deserialization (#46), Debug/Display for empty pollard (#48) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-L2L
force-pushed
the
main
branch
2 times, most recently
from
2652dd7
to
64d5cf0
Compare
Ash-L2L
changed the title
Ash-L2L
changed the title
|
Thank you for this PR! Just some comments |
Davidson-Souza
requested changes
May 16, 2024
Davidson-Souza
approved these changes
May 20, 2024
Davidson-Souza
added a commit
to Davidson-Souza/rustreexo
that referenced
this pull request
Jun 8, 2024
After we broadcast a transaction, this should reflect our address's balance
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46, #48.
This fix is not backwards-compatible as the serialization encoding is changed. I have bumped the version number to reflect this.