parent_many: force a constant to u64 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, in 64 bits machine rustc will interpret constants as u32, but in parent_many we left shift a constant by the depth of the forest, which can be grather than 32. This would a 32-bits value to be left-shifted by more than 32. This is undefined behavour and should be avoided. This commit coerces the constants to u64, making it safe shift up to 63. Since tree with depth 63 would be impossible to see in practice (it would represent quadrilions of leaves), there's no risk of having the same UB now.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, in 64 bits machine rustc will interpret constants as u32, but in parent_many we left shift a constant by the depth of the forest, which can be grather than 32. This would a 32-bits value to be left-shifted by more than 32. This is undefined behavour and should be avoided.
This commit coerces the constants to u64, making it safe shift up to 63. Since tree with depth 63 would be impossible to see in practice (it would represent quadrilions of leaves), there's no risk of having the same UB now.