Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

shorten submodule text #379

Merged
merged 2 commits into from
Apr 9, 2022
Merged

shorten submodule text #379

merged 2 commits into from
Apr 9, 2022

Conversation

jacksund
Copy link
Contributor

@jacksund jacksund commented Apr 9, 2022

fixes #374

Note, I haven't added functionality to keep the original verbose names. This PR forces the new format of short names.

@mhils
Copy link
Member

mhils commented Apr 9, 2022

This looks good to me. Would you mind adding a CHANGELOG entry? :)
(and you likely need to rebase onto main one more time)

@jacksund
Copy link
Contributor Author

jacksund commented Apr 9, 2022

looks like the CI is still going wacky -- even on the main branch. Not sure if I messed things up, but sorry to start this 😓

@jacksund
Copy link
Contributor Author

jacksund commented Apr 9, 2022

@mhils I rebased and also updated snapshots with nodejs installed. Any idea where I'm messing things up?

@mhils
Copy link
Member

mhils commented Apr 9, 2022

Yeah - I accidentally pushed an incomplete fix and broke main myself. 😅 Sorry - should be all set now.

@mhils mhils enabled auto-merge (squash) April 9, 2022 16:47
@mhils mhils merged commit 2d8a6cb into mitmproxy:main Apr 9, 2022
@davfsa davfsa mentioned this pull request May 10, 2022
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shortened submodule names by default
2 participants