Try Support ActiveRecord 6.1.Z #25
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirocaster
reviewed
May 31, 2024
| @@ -32,6 +32,7 @@ module ActiveRecordExt | |||
| ActiveRecord::ConnectionAdapters::ConnectionHandler.prepend(ConnectionHandlerExtension) | |||
| ActiveRecord::Associations::Preloader::Association.prepend(AssociationPreloader) | |||
| ActiveRecord::Associations::Association.prepend(Association) | |||
| ActiveRecord::Associations::Builder::Association.singleton_class.prepend(Builder::Association) | |||
| @@ -83,16 +83,11 @@ def setup_fixtures(config = ActiveRecord::Base) | |||
| @fixture_connections = [] | |||
| @@already_loaded_fixtures ||= {} | |||
| @connection_subscriber = nil | |||
| @legacy_saved_pool_configs = Hash.new { |hash, key| hash[key] = {} } | |||
There was a problem hiding this comment.
この辺りは ActiveRecord::TestFixtures で定義されてるやつを真似しただけ
rails/rails#40384
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主に以下の変更に対して対応をした
retrieve_connection_poolの引数が変わったconnected_toandconnects_tofor horizontal sharding rails/rails#38531pool_keytoshardand use kwargs for connection methods rails/rails#40006ConnectionPool#specがなくなった（db_configを挟むようになった？）add_to_transactionの引数が変わったsync_with_transaction_stateto simplify code base rails/rails#39121ActiveRecord::Base.configurations[env]が Hash を返さなくなったTestFixturesが新しくインスタンス変数を持つようになったUNSUPPORTED_PROXY_METHODSは、AR6.1 で増えたメソッドをとりあえず無視している