-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for native MongoDB driver #24
Support for native MongoDB driver #24
Conversation
can you add a unit test? |
One potential problem I see with this is that it will provide unexpected results if the |
The callback is actually optional. Check the function return type and and code handling the missing callback. |
@ghmeier is manofish/mongojs a supported driver? I was under the impression only mongoist was supported. Would it be sufficient to update the README to point out the supported drivers are mongoist and, with this PR, native mongodb? @bradvogel will update with unit tests soon (hopefully tomorrow). |
Ok, I've added tests and updated the README that the native driver is supported. Have a look and let me know if anything else is needed. WRT the tests, I had some issues with looping the tests through both drivers. I couldn't manage to get the concurrency to operate correctly, so the tests where not reliably running with the correct driver (the driver was replaced in the |
Great thanks! Will review in the next 2days. Sorry for the delay |
Thanks! Released as 6.1.0. |
This PRs makes the package work with the native MongoDB Node.js driver, as well as with mongoist.
The tests pass but I’ve not added any new to test with the native driver. Hope that’s OK?