Doc tweaks - min/max_spare_servers and some typo fixes & rewording #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't clearly documented before, in my opinion; i had to delve into the code to find out how to allow the number of worker processes to adapt to the load, rather than being fixed.
I think this reads ever so slightly more naturally, although both forms are considered correct.
bin/starman
Outdated
| @@ -37,6 +37,7 @@ starman - Starman launcher | |||
|
|
|||
| starman --listen :5001 --listen /tmp/starman.sock | |||
| starman --workers 32 --port 8080 | |||
| starman --min_spare_severs 2 --max_spare_servers 4 --max_servers 10 | |||
There was a problem hiding this comment.
you can use - and plack handler automatically converts to _. i.e. starman --min-spare-servers 2 ... I prefer the use of -.
There was a problem hiding this comment.
OK, made that change.... slightly slow response there, I must admit ;)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
min_spare_servers,max_spare_servers,max_serversoptions weren't clearly documented, I had to look at the code to find out how to let Starman dynamically start more workers to handle the current load (within defined limits).I've added these to the documentation in
bin/starman, and also fixed some typos and improved the clarity of some parts while I was there :)