Fixed player splash potions not working and reworked potion dispense behaviour #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, all splash potions are blocked rather than just the ones that are thrown by dispensers.
Dispenser splash potion cancelling should only apply when shot out of a dispenser, and not affect players or witches.
All splashes should be disabled if inside of the claim as the cloud itself is a form of griefing.
This handles the edge case if the lingering potion cloud is splashed on the outer edge of a claim, which causes the cloud formation to extend into the claim. For the non monster entities that would be affected, they are taken out of the affected list.
This should perform the check like the lingering potions, where if the potion itself lands inside the claim, it should just be cancelled entirely and only need to perform the per entity checks if dispensed on the outer edge of the claim.
This ensures that the check to see if the potion affects the entities within the claim still works even if no entities are hit.
This is under the mob griefing umbrella where witches should not be able to affect animals or villagers with potions.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially just supposed to be a fix of the dispenser flag overextending its protection to players throwing splash potions in claims, but ended up with a bit more than that.
Dispensed potions now disappear if they originated from outside the claim and landed inside the claim. The filtering of hostile mobs and passive mobs still apply if the splash happens outside the claim but affects entities inside the claim. This behaviour is also shared with lingering potions.
Another addition is the protection from witch potions, as witches throwing potions should not be able to affect passive mobs.