Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added configurable visualiser delay period on claim tool unequip #88

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

mizarc
Copy link
Owner

@mizarc mizarc commented Oct 13, 2024

This resolves potential lag when a player decides to rapidly equip and unequip the claim tool, which causes the visualiser to recalculate itself every single time it is triggered. A value can be modified in the config to set how long the visualiser remains before being hidden.

A new function has been added to the visualiser class that can be used
to delay a visualiser hide event. This is stored in the player state
to make it cancellable if the visualiser stick is taken back out before
it is scheduled to hide.
This now check to see if the delay period is greater than 0 in the
config, and uses the delay branch rather than the instant hide/show
process.
This nested far too much to be in the current function.
@mizarc mizarc added the enhancement New feature or request label Oct 13, 2024
@mizarc mizarc self-assigned this Oct 13, 2024
@mizarc mizarc merged commit 895e3b7 into release/0.3 Oct 13, 2024
1 check passed
@mizarc mizarc deleted the feature/visualiser-hide-delay-period branch October 15, 2024 02:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant