Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to Bazel 7.4.1 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpwoodbu
Copy link

@rpwoodbu rpwoodbu commented Dec 2, 2024

This requires disabling Bzlmod and cc toolchain resolution. Both of these should be supported in the future.

This requires disabling Bzlmod and cc toolchain resolution. Both of these
should be supported in the future.
@rpwoodbu
Copy link
Author

rpwoodbu commented Dec 2, 2024

I have another branch behind this one to add support for Bazel's platforms and cc toolchain resolution. To avoid a merge conflict, I'll send that PR once this has (hopefully) merged.

@jpieper
Copy link
Member

jpieper commented Dec 3, 2024

Hi, thanks for the patch!

My bandwidth is limited this month, and for my purposes, I have about a dozen other repos that I want to keep the bazel version in sync on so it may be a while before I can check this. In the meantime, can you share a branch that has the platform work? I'm not opposed to upstreaming that either, although as with this I have other constraints that may make it take longer to review.

@rpwoodbu
Copy link
Author

rpwoodbu commented Dec 4, 2024

Thanks for the quick reply. I get it; I'm often in the same boat. No rush.

I linked to the platform branch in my previous comment, but here it is again. It should work with Bazel 5, so we could merge without upgrading Bazel if you prefer. Let me know if you'd like me to send that PR.

I'd also be interested in adding Bzlmod support to this repo. Again, that wouldn't break Bazel 5 as it just wouldn't use those bits. It wouldn't be tested with Travis, though (is that even working?). It could be considered experimental. It'd be nice to have your toolchain in the Bzlmod registry. Again, let me know if you'd like that PR. (If that might not get upstreamed, I probably wouldn't bother to do it just for my own fork.)

@rpwoodbu
Copy link
Author

rpwoodbu commented Dec 27, 2024

FYI: I have actually invested some effort on Bzlmod support. With Bazel 8 now released, I wanted to get rid of its warning about the use of a WORKSPACE file. But I found that it is a little awkward to maintain support for Bazel 5 in the process, due to Bzlmod's "canonical repo names" and thus how the paths under external must be constructed. Let me know if maintaining Bazel 5 support long-term is important to you. If not, I won't bother. Bazel 6.5+ should work without issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants