Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: reporting the attribute who lost their value #225

Merged
merged 5 commits into from
Nov 11, 2023
Merged

fix: reporting the attribute who lost their value #225

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8976fe0
fix(API Checks): report the attribute who lost their value
Nov 10, 2023
c115060
fix(API Checks): passing unset in breakng instance instead of setting…
Nov 10, 2023
7a822e2
fix(API Checks): moved into if else block
Nov 11, 2023
c71ecb9
fix(API Checks): added unit test
Nov 11, 2023
f40d7a2
fix(API Checks): fixed typo
Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/griffe/diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,8 @@ def _attribute_incompatibilities(old_attribute: Attribute, new_attribute: Attrib
# if old_attribute.annotation is not None and new_attribute.annotation is not None:
# if not is_subhint(new_attribute.annotation, old_attribute.annotation):
if old_attribute.value != new_attribute.value:
if new_attribute.value is None:
new_attribute.value = "unset"
yield AttributeChangedValueBreakage(new_attribute, old_attribute.value, new_attribute.value)


Expand Down