Do not allow exceptions in Cursor destructor (#585)

mkleehammer · Apr 11, 2023 · 5ab74b3 · 5ab74b3
1 parent 6b107a2
commit 5ab74b3
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/cursor.cpp b/src/cursor.cpp
@@ -458,6 +458,10 @@ static void Cursor_dealloc(Cursor* cursor)
     if (Cursor_Validate((PyObject*)cursor, CURSOR_REQUIRE_CNXN))
     {
         closeimpl(cursor);
+        if (PyErr_Occurred()) {
+            // We are in a Cursor destructor (__del__) and should not raise exceptions.
+            PyErr_Clear();
+        }
     }
     Py_XDECREF(cursor->inputsizes);
     PyObject_Del(cursor);