Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not pin requirements in setup #199

Closed
pombredanne opened this issue Oct 11, 2021 · 3 comments
Closed

Do not pin requirements in setup #199

pombredanne opened this issue Oct 11, 2021 · 3 comments

Comments

@pombredanne
Copy link
Contributor

In

regipy/setup.py

Line 38 in a6bcdab

'pytz==2021.1'],
you pin requirements such as for pytz. This makes it it impossible to use the newer version of of pytz 2021.3
It is OK to use pins in https://github.com/mkorman90/regipy/blob/master/requirements.txt .... but you should have relaxed version constraints in setup.py
See https://caremad.io/posts/2013/07/setup-vs-requirement/ to get why this matters
@pombredanne
Copy link
Contributor Author

pombredanne commented Oct 11, 2021 •
edited
Loading

This is a blocker for aboutcode-org/scancode.io#342

pombredanne added a commit to pombredanne/regipy that referenced this issue Oct 11, 2021
@pombredanne
Relax setup.py requirements
0ea1da1 
Do not pin versions in setup.py to allow usage as a library
such as in scancode.io

Reference: mkorman90#199
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Oct 11, 2021
Merged
pombredanne added a commit to aboutcode-org/regipy that referenced this issue Oct 12, 2021
@pombredanne
Rename package for temporary advanced release
a438365 
This is a temporary advanced patched package, with relaxed dependency
constraints. It is there only until upstream is updated.

Reference: mkorman90#199
Reference: mkorman90#200
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@tincho9
Copy link
Collaborator

tincho9 commented Oct 26, 2021

Can I close this?

@pombredanne
Copy link
Contributor Author

@tincho9 sure! let me close.
A new release would be mucho welcomed too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @tincho9