Pass content to DeadboltHandler.beforeAuthCheck as well #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content is the one passed to the `@Constraint`. For `@BeforeAccess` this means it now also has a `content` parameter.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also be able to react to the
contentwhen returning a non-empty result inbeforeAuthCheck(not just inonAuthFailure).The
contentis the one passed to the@Constraint.For
@BeforeAccessthis means it now also has acontentparameter. Makes sense to me.This enhancement allows me to generalise the code even better in one of my next pull requests (and therefore make the code safer).