Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move /mlflow/traces/{request_id}/tags endpoint. #11

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Oct 8, 2024

No description provided.

Signed-off-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Signed-off-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Signed-off-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Signed-off-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@nojaf
Copy link
Collaborator

nojaf commented Oct 9, 2024

@dsuhinin, I made the error message more consistent on the Python side of things, you need mlflow/mlflow#13358 to pass tests/store/tracking/test_sqlalchemy_store.py::test_set_invalid_tag

@dsuhinin
Copy link
Collaborator Author

@dsuhinin, I made the error message more consistent on the Python side of things, you need mlflow/mlflow#13358 to pass tests/store/tracking/test_sqlalchemy_store.py::test_set_invalid_tag

ook, I see. then let's wait when it will be merged. thank you!

@dsuhinin dsuhinin marked this pull request as ready for review October 10, 2024 07:58
@nojaf
Copy link
Collaborator

nojaf commented Oct 14, 2024

@dsuhinin I was able to merge the upstream PR.

@dsuhinin
Copy link
Collaborator Author

@dsuhinin I was able to merge the upstream PR.

nice!

…so now all tests are green.

Signed-off-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@dsuhinin dsuhinin requested a review from nojaf October 14, 2024 12:15
@dsuhinin dsuhinin merged commit 2f25223 into mlflow:main Oct 14, 2024
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants