Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve Windows #62

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Improve Windows #62

merged 1 commit into from
Oct 15, 2024

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Oct 15, 2024

No description provided.

@nojaf
Improve Windows
9535ad3 
Signed-off-by: nojaf <florian.verdonck@outlook.com>
@nojaf nojaf requested a review from jgiannuzzi October 15, 2024 11:33
jgiannuzzi
jgiannuzzi approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, you are a Windows+Go+CFFI guru now!

@nojaf nojaf merged commit ef755cb into mlflow:main Oct 15, 2024
25 checks passed
@nojaf
Copy link
Collaborator Author

nojaf commented Oct 15, 2024

Great stuff, you are a Windows+Go+CFFI guru now!

Sure 🫠🙄😴

@nojaf nojaf linked an issue Oct 15, 2024 that may be closed by this pull request
Fix Python tests on Windows platform #19
Closed
@nojaf nojaf linked an issue Nov 7, 2024 that may be closed by this pull request
Fix ffi issue on Windows #15
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jgiannuzzi jgiannuzzi jgiannuzzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Python tests on Windows platform Fix ffi issue on Windows
2 participants
@nojaf @jgiannuzzi